[PATCH v2] iommu/omap: Fix missing put_device() call in omap_iommu_probe_device

From: Miaoqian Lin
Date: Tue Mar 01 2022 - 01:33:51 EST


The reference taken by 'of_find_device_by_node()' must be released when
not needed anymore.
Add the corresponding 'put_device()' in the error handling path and
the regular path.

Fixes: ede1c2e7d4dc ("iommu/omap: Store iommu_dev pointer in arch_data")
Signed-off-by: Miaoqian Lin <linmq006@xxxxxxxxx>
---
changes in v2:
- move put_device() before of_node_put().
- add put_device() in the regular path.
---
drivers/iommu/omap-iommu.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
index 91749654fd49..2222b30a0a00 100644
--- a/drivers/iommu/omap-iommu.c
+++ b/drivers/iommu/omap-iommu.c
@@ -1683,6 +1683,7 @@ static struct iommu_device *omap_iommu_probe_device(struct device *dev)

oiommu = platform_get_drvdata(pdev);
if (!oiommu) {
+ put_device(&pdev->dev);
of_node_put(np);
kfree(arch_data);
return ERR_PTR(-EINVAL);
@@ -1691,6 +1692,7 @@ static struct iommu_device *omap_iommu_probe_device(struct device *dev)
tmp->iommu_dev = oiommu;
tmp->dev = &pdev->dev;

+ put_device(&pdev->dev);
of_node_put(np);
}

--
2.17.1