Re: [PATCH V3] tty: serial: meson: Fix the compile link error reported by kernel test robot

[Jerome Brunet]

On Tue 01 Mar 2022 at 15:47, Yu Tu <yu.tu@xxxxxxxxxxx> wrote:

> Hi Neil,
>
> On 2022/3/1 15:23, Neil Armstrong wrote:
>> [ EXTERNAL EMAIL ]
>> Hi Greg,
>> Le 28/02/2022 à 22:21, Greg Kroah-Hartman a écrit :
>>> On Mon, Feb 28, 2022 at 03:13:48PM +0100, Neil Armstrong wrote:
>>>> Hi,
>>>>
>>>> On 28/02/2022 14:55, Yu Tu wrote:
>>>>> Describes the calculation of the UART baud rate clock using a clock
>>>>> frame. Forgot to add in Kconfig kernel test Robot compilation error
>>>>> due to COMMON_CLK dependency.
>>>>>
>>>>> Fixes: ("tty: serial:meson: Describes the calculation of the UART baud
>>>>> rate clock using a clock frame“)
>>>>
>>>> As I already replied on V2 of this patch, you're invited to apply these
>>>> fixes directly
>>>> on the next version of your "Use CCF to describe the UART baud rate
>>>> clock" patchset
>>>> and not as a separate patch.
>>>
>>> No, this is broken in linux-next now as the path listed here is in my
>>> tree right now.
>> Oh, I wasn't aware you took this patchset.
>> 
>>>
>>> I need a fix for it, or I can revert the original.
>> Please revert the whole patchset, it's not ready yet, neither fully 
>> reviewed ands buggy
>> on old SoCs.
> I have tested that there is no problem with G12A and S4 boards. Can I merge
> them first and fix them later if there is any problem?

That's called a regression. That is not how we do things in mainline
There is still a lot of people using GXL boards. Those are still sold even.

>> Thanks,
>> Neil
>> 
>>>
>>> thanks,
>>>
>>> greg k-h
>>