Re: [PATCH v2 4/7] octeon_ep: add Tx/Rx ring resource setup and cleanup
From: kernel test robot
Date: Tue Mar 01 2022 - 03:53:19 EST
Hi Veerasenareddy,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.17-rc6 next-20220228]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Veerasenareddy-Burru/Add-octeon_ep-driver/20220301-130525
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 719fce7539cd3e186598e2aed36325fe892150cf
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20220301/202203011646.KOYQZTf2-lkp@xxxxxxxxx/config)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/4f90d53a8dea4a3aa77ba5ba8d34d576b81bd773
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Veerasenareddy-Burru/Add-octeon_ep-driver/20220301-130525
git checkout 4f90d53a8dea4a3aa77ba5ba8d34d576b81bd773
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash drivers/net/ethernet/marvell/octeon_ep/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All warnings (new ones prefixed by >>):
drivers/net/ethernet/marvell/octeon_ep/octep_tx.c: In function 'octep_setup_iq':
drivers/net/ethernet/marvell/octeon_ep/octep_tx.c:110:14: error: implicit declaration of function 'vzalloc'; did you mean 'kvzalloc'? [-Werror=implicit-function-declaration]
110 | iq = vzalloc(sizeof(*iq));
| ^~~~~~~
| kvzalloc
>> drivers/net/ethernet/marvell/octeon_ep/octep_tx.c:110:12: warning: assignment to 'struct octep_iq *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
110 | iq = vzalloc(sizeof(*iq));
| ^
>> drivers/net/ethernet/marvell/octeon_ep/octep_tx.c:148:23: warning: assignment to 'struct octep_tx_buffer *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
148 | iq->buff_info = vzalloc(buff_info_size);
| ^
drivers/net/ethernet/marvell/octeon_ep/octep_tx.c:178:9: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
178 | vfree(iq);
| ^~~~~
| kvfree
cc1: some warnings being treated as errors
--
drivers/net/ethernet/marvell/octeon_ep/octep_rx.c: In function 'octep_setup_oq':
drivers/net/ethernet/marvell/octeon_ep/octep_rx.c:83:14: error: implicit declaration of function 'vzalloc'; did you mean 'kvzalloc'? [-Werror=implicit-function-declaration]
83 | oq = vzalloc(sizeof(*oq));
| ^~~~~~~
| kvzalloc
>> drivers/net/ethernet/marvell/octeon_ep/octep_rx.c:83:12: warning: assignment to 'struct octep_oq *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
83 | oq = vzalloc(sizeof(*oq));
| ^
>> drivers/net/ethernet/marvell/octeon_ep/octep_rx.c:116:25: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
116 | oq->buff_info = (struct octep_rx_buffer *)
| ^
drivers/net/ethernet/marvell/octeon_ep/octep_rx.c:134:9: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
134 | vfree(oq->buff_info);
| ^~~~~
| kvfree
cc1: some warnings being treated as errors
vim +110 drivers/net/ethernet/marvell/octeon_ep/octep_tx.c
95
96 /**
97 * octep_setup_iq() - Setup a Tx queue.
98 *
99 * @oct: Octeon device private data structure.
100 * @q_no: Tx queue number to be setup.
101 *
102 * Allocate resources for a Tx queue.
103 */
104 static int octep_setup_iq(struct octep_device *oct, int q_no)
105 {
106 u32 desc_ring_size, buff_info_size, sglist_size;
107 struct octep_iq *iq;
108 int i;
109
> 110 iq = vzalloc(sizeof(*iq));
111 if (!iq)
112 goto iq_alloc_err;
113 oct->iq[q_no] = iq;
114
115 iq->octep_dev = oct;
116 iq->netdev = oct->netdev;
117 iq->dev = &oct->pdev->dev;
118 iq->q_no = q_no;
119 iq->max_count = CFG_GET_IQ_NUM_DESC(oct->conf);
120 iq->ring_size_mask = iq->max_count - 1;
121 iq->fill_threshold = CFG_GET_IQ_DB_MIN(oct->conf);
122 iq->netdev_q = netdev_get_tx_queue(iq->netdev, q_no);
123
124 /* Allocate memory for hardware queue descriptors */
125 desc_ring_size = OCTEP_IQ_DESC_SIZE * CFG_GET_IQ_NUM_DESC(oct->conf);
126 iq->desc_ring = dma_alloc_coherent(iq->dev, desc_ring_size,
127 &iq->desc_ring_dma, GFP_KERNEL);
128 if (unlikely(!iq->desc_ring)) {
129 dev_err(iq->dev,
130 "Failed to allocate DMA memory for IQ-%d\n", q_no);
131 goto desc_dma_alloc_err;
132 }
133
134 /* Allocate memory for hardware SGLIST descriptors */
135 sglist_size = OCTEP_SGLIST_SIZE_PER_PKT *
136 CFG_GET_IQ_NUM_DESC(oct->conf);
137 iq->sglist = dma_alloc_coherent(iq->dev, sglist_size,
138 &iq->sglist_dma, GFP_KERNEL);
139 if (unlikely(!iq->sglist)) {
140 dev_err(iq->dev,
141 "Failed to allocate DMA memory for IQ-%d SGLIST\n",
142 q_no);
143 goto sglist_alloc_err;
144 }
145
146 /* allocate memory to manage Tx packets pending completion */
147 buff_info_size = OCTEP_IQ_TXBUFF_INFO_SIZE * iq->max_count;
> 148 iq->buff_info = vzalloc(buff_info_size);
149 if (!iq->buff_info) {
150 dev_err(iq->dev,
151 "Failed to allocate buff info for IQ-%d\n", q_no);
152 goto buff_info_err;
153 }
154
155 /* Setup sglist addresses in tx_buffer entries */
156 for (i = 0; i < CFG_GET_IQ_NUM_DESC(oct->conf); i++) {
157 struct octep_tx_buffer *tx_buffer;
158
159 tx_buffer = &iq->buff_info[i];
160 tx_buffer->sglist =
161 &iq->sglist[i * OCTEP_SGLIST_ENTRIES_PER_PKT];
162 tx_buffer->sglist_dma =
163 iq->sglist_dma + (i * OCTEP_SGLIST_SIZE_PER_PKT);
164 }
165
166 octep_iq_reset_indices(iq);
167 oct->hw_ops.setup_iq_regs(oct, q_no);
168
169 oct->num_iqs++;
170 return 0;
171
172 buff_info_err:
173 dma_free_coherent(iq->dev, sglist_size, iq->sglist, iq->sglist_dma);
174 sglist_alloc_err:
175 dma_free_coherent(iq->dev, desc_ring_size,
176 iq->desc_ring, iq->desc_ring_dma);
177 desc_dma_alloc_err:
178 vfree(iq);
179 oct->iq[q_no] = NULL;
180 iq_alloc_err:
181 return -1;
182 }
183
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx