RE: [PATCH] [PATCH v2] AARCH64: Add gcc Shadow Call Stack support

[David Laight]

From: Miguel Ojeda
> Sent: 01 March 2022 09:29
> 
> On Mon, Feb 28, 2022 at 11:35 PM Nick Desaulniers
> <ndesaulniers@xxxxxxxxxx> wrote:
> >
> > Or simply add a #define for __noscs to include/linux/compiler-gcc.h
> > with appropriate guard and leave the existing #ifndef in
> > include/linux/compiler_types.h as is.  I'd prefer that when the
> > compilers differ in terms of feature detection since it's as explicit
> > as possible.
> 
> The idea is to avoid differing here to begin with, i.e. to use the
> same code for both compilers (only whenever that is possible, of
> course), thus having a single `#define` in a single file.
> 
> Do you think we will have to change in the future for some reason,
> thus needing to split it again?

What happens if an out of tree module is compiled with the other compiler?
Surely this is part of the ABI and should be defined for the architecture?

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)