Re: [PATCH V5 2/5] dt-bindings: mailbox: imx-mu: add i.MX93 S4 MU support

[Rob Herring]

On Mon, Feb 28, 2022 at 10:40:10AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@xxxxxxx>
> 
> Similar to i.MX8ULP S4 MU, i.MX93 MU is dedicated for communication
> between Sentinel and Cortex-A cores from hardware design, it could not be
> reused for other purpose.
> 
> However i.MX93 S4 MU use separate tx/rx interrupt, so update
> interrupts and add interrupt-names property.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> ---
> 
> 
> Hi Rob,
>  For dual entries, I tested below with dt_binding_check and dtbs_check
>  "
>  +		s4muap: s4muap@47520000 {
>  +			compatible = "fsl,imx93-mu-s4";
>  +			reg = <0x47520000 0x10000>;
>  +			interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
>  +			interrupt-names = "tx", "rx";
>  +			#mbox-cells = <2>;
>  +			status = "okay";
>  +		};
>  +
>  +		s4muap1: s4muap@48520000 {
>  +			compatible = "fsl,imx8ulp-mu-s4";
>  +			reg = <0x48520000 0x10000>;
>  +			interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
>  +			interrupt-names = "tx", "rx";

Well, that's wrong, but we don't check the length of 'foo-names' against 
'foo'.

>  +			#mbox-cells = <2>;
>  +			status = "okay";
>  +		};
>  "
> 
>  .../devicetree/bindings/mailbox/fsl,mu.yaml   | 28 ++++++++++++++++++-
>  1 file changed, 27 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> index 6d056d5e16bf..82ce0280add9 100644
> --- a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> @@ -29,6 +29,7 @@ properties:
>        - const: fsl,imx8ulp-mu
>        - const: fsl,imx8-mu-scu
>        - const: fsl,imx8-mu-seco
> +      - const: fsl,imx93-mu-s4
>        - const: fsl,imx8ulp-mu-s4
>        - items:
>            - const: fsl,imx93-mu
> @@ -55,7 +56,14 @@ properties:
>      maxItems: 1
>  
>    interrupts:
> -    maxItems: 1
> +    minItems: 1
> +    maxItems: 2
> +
> +  interrupt-names:
> +    minItems: 1
> +    items:
> +      - const: tx
> +      - const: rx
>  
>    "#mbox-cells":
>      description: |
> @@ -90,6 +98,24 @@ required:
>    - interrupts
>    - "#mbox-cells"
>  
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - fsl,imx93-mu-s4
> +    then:
> +      properties:
> +        interrupt-names:
> +          minItems: 2
> +        interrupts:
> +          minItems: 2
> +
> +    else:
> +      properties:
> +        interrupts:
> +          maxItems: 1

You could add:

         not:
           required:
             - interrupt-names

Otherwise,

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>