Re: [PATCH v8 1/1] tpm: fix reference counting for struct tpm_chip

[Lino Sanfilippo]

On 01.03.22 at 15:05, Jason Gunthorpe wrote:
> On Tue, Mar 01, 2022 at 03:21:08AM +0100, Lino Sanfilippo wrote:
>> @@ -653,8 +623,10 @@ void tpm_chip_unregister(struct tpm_chip *chip)
>>  	if (IS_ENABLED(CONFIG_HW_RANDOM_TPM) && !tpm_is_firmware_upgrade(chip))
>>  		hwrng_unregister(&chip->hwrng);
>>  	tpm_bios_log_teardown(chip);
>> -	if (chip->flags & TPM_CHIP_FLAG_TPM2 && !tpm_is_firmware_upgrade(chip))
>> +	if (chip->flags & TPM_CHIP_FLAG_TPM2 && !tpm_is_firmware_upgrade(chip)) {
>>  		cdev_device_del(&chip->cdevs, &chip->devs);
>> +		put_device(&chip->devs);
>> +	}
>
> I would put those two lines in a function bside tpm_devs_add() as
> well, more modular.
>

Agreed, I will put this in a tpm_devs_remove() function as counterpart to tpm_devs_add().

Regards,
Lino