Re: [PATCH 3/4] usb: typec: add TUSB320xA driver

[Alvin Šipraga]

kernel test robot <lkp@xxxxxxxxx> writes:

> Hi "Alvin,
>
> I love your patch! Perhaps something to improve:
>

<snip>

>
> All warnings (new ones prefixed by >>):
>
>>> drivers/usb/typec/tusb320xa.c:407:6: warning: no previous prototype for 'tusb320xa_action_role_sw_put' [-Wmissing-prototypes]
>      407 | void tusb320xa_action_role_sw_put(void *data)
>          |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> drivers/usb/typec/tusb320xa.c:414:6: warning: no previous prototype for 'tusb320xa_action_unregister_port' [-Wmissing-prototypes]
>      414 | void tusb320xa_action_unregister_port(void *data)
>          |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Ah yes, these should be static, will fix in v2. Thank you, test robot.

>
>
> vim +/tusb320xa_action_role_sw_put +407 drivers/usb/typec/tusb320xa.c
>
>    406	
>  > 407	void tusb320xa_action_role_sw_put(void *data)
>    408	{
>    409		struct usb_role_switch *role_sw = data;
>    410	
>    411		usb_role_switch_put(role_sw);
>    412	}
>    413	
>  > 414	void tusb320xa_action_unregister_port(void *data)
>    415	{
>    416		struct typec_port *port = data;
>    417	
>    418		typec_unregister_port(port);
>    419	}
>    420	
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx