Re: [PATCH] nvmem: check for allocation failure
From: Christophe JAILLET
Date: Tue Mar 01 2022 - 13:10:34 EST
Le 01/03/2022 à 09:11, Dan Carpenter a écrit :
Check for if the kcalloc() fails.
Fixes: 299dc152721f ("nvmem: brcm_nvram: parse NVRAM content into NVMEM cells")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
---
drivers/nvmem/brcm_nvram.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/nvmem/brcm_nvram.c b/drivers/nvmem/brcm_nvram.c
index 439f00b9eef6..c80af8a31eba 100644
--- a/drivers/nvmem/brcm_nvram.c
+++ b/drivers/nvmem/brcm_nvram.c
@@ -95,6 +95,8 @@ static int brcm_nvram_parse(struct brcm_nvram *priv)
len = le32_to_cpu(header.len);
data = kcalloc(1, len, GFP_KERNEL);
Hi,
just for my understanding, why
- kcalloc(1, len) and not kzalloc(len)?
- kcalloc and not kmalloc_array, since data is fully filled just the
line below by memcpy_fromio()?
CJ
+ if (!data)
+ return -ENOMEM;
memcpy_fromio(data, priv->base, len);
data[len - 1] = '\0';