Re: [RFC 1/1] tty: n_gsm: improve standard compliance and feature completeness
From: Greg KH
Date: Wed Mar 02 2022 - 10:00:04 EST
On Wed, Mar 02, 2022 at 02:47:20PM +0000, Starke, Daniel wrote:
> Thank you for this quick response.
>
> > I'm sorry, but there is nothing we can do with such a large patch here at
> > all.
> >
> > Please break this up into "one logical change per patch" and we will be
> > glad to review it.
>
> You are absolutely right but this is still work in progress. The attached
> patch was only for reference for all those who would like to look at the
> changes in detail or try out the proposed work. This was not a request for
> code review yet. Also, it seems that the patch was too large for the
> linux-serial mailing list so I have uploaded it here for reference:
> https://github.com/siemens/linux/tree/dstarke-siemens/n_gsm_rfc
You need to provide a set of patches for people to review. Random code
dumps and random github links are impossible to review cleanly, would
you want to to so?
thanks,
greg k-h