Re: [greybus-dev] Re: [PATCH] staging: greybus: loopback: Fix Coding Style Error

[Alex Elder]

On 2/17/22 10:52 PM, Ahamed Husni wrote:
> Hi Greg,
>
> On Fri, Feb 18, 2022 at 12:56 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > Did you try to build this change?
>
> I am a newbie kernel dev and trying to understand how things work.
> I did not build this change by the time I sent you this, thinking this
> is just a style change.
> I should have tested the build. I am sorry.
>
> Now I built the changes by setting the following configurations.
> CONFIG_GREYBUS
> CONFIG_STAGING
> CONFIG_GREYBUS_LOOPBACK
>
> My change introduces the following error.
> ''''
> drivers/staging/greybus/loopback.c:166:2: error: expected identifier
> or ‘(’ before ‘do’
>    166 |  do {            \
>        |  ^~
> ''''
> I could not fix or find the reason for this error. Please guide me in
> this regard.

You should understand that you cannot contribute to the Linux
kernel if you don't understand details of the C language well.
And you really must test your changes (certainly a build test)
before you send them for review.

To answer your question, the macro you changed does not
expand into code that is itself incorporated in an executable
block.  The macro is used to generate entire functions in a
unified way.

					-Alex

> Thanks,
> Husni.
> _______________________________________________
> greybus-dev mailing list -- greybus-dev@xxxxxxxxxxxxxxxx
> To unsubscribe send an email to greybus-dev-leave@xxxxxxxxxxxxxxxx