Re: [PATCH v3] arm64: Do not defer reserve_crashkernel() for platforms with no DMA memory zones
From: Pasha Tatashin
Date: Wed Mar 02 2022 - 13:15:57 EST
Hi Vijay,
The patch looks good to me, just one nit below.
> -phys_addr_t arm64_dma_phys_limit __ro_after_init;
> +#if IS_ENABLED(CONFIG_ZONE_DMA) || IS_ENABLED(CONFIG_ZONE_DMA32)
> +phys_addr_t __ro_after_init arm64_dma_phys_limit;
> +#else
> +phys_addr_t __ro_after_init arm64_dma_phys_limit = PHYS_MASK + 1;
Since in this case arm64_dma_phys_limit is initialized during
declaration, it would make sense to use const instead of
__ro_after_init. Consider changing the above to this:
const phys_addr_t arm64_dma_phys_limit = PHYS_MASK + 1;
Reviewed-by: Pasha Tatashin <pasha.tatashin@xxxxxxxxxx>
Thank you,
Pasha