Re: [PATCH 2/4] dt-bindings: usb: add TS5USBA224 USB/Audio switch mux
From: Rob Herring
Date: Wed Mar 02 2022 - 13:21:46 EST
On Tue, Mar 01, 2022 at 02:20:06PM +0100, Alvin Šipraga wrote:
> From: Alvin Šipraga <alsi@xxxxxxxxxxxxxxx>
>
> The TS5USBA224 is a USB High Speed/Audio switch mux IC controlled via
> GPIO. It is typically composed with a Type-C port controller with Audio
> Accessory mode detection.
>
> Signed-off-by: Alvin Šipraga <alsi@xxxxxxxxxxxxxxx>
> ---
> .../bindings/usb/ti,ts5usba224.yaml | 56 +++++++++++++++++++
> 1 file changed, 56 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/ti,ts5usba224.yaml
>
> diff --git a/Documentation/devicetree/bindings/usb/ti,ts5usba224.yaml b/Documentation/devicetree/bindings/usb/ti,ts5usba224.yaml
> new file mode 100644
> index 000000000000..0a488b961906
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ti,ts5usba224.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/ti,ts5usba224.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TS5USBA224 USB 2.0 High Speed and Audio mux DT bindings
> +
> +description:
> + The Texas Instruments TS5USBA224 is a double-pole, double throw
> + (DPDT) multiplexer that includes a low-distortion audio switch and a
> + USB 2.0 High Speed switch in the same package.
> +
> +maintainers:
> + - Alvin Šipraga <alsi@xxxxxxxxxxxxxxx>
> +
> +properties:
> + compatible:
> + enum:
> + - ti,ts5usba224
> +
> + asel-gpio:
> + description: Output GPIO for A_SEL signal
> + maxItems: 1
> +
> + accessory:
> + type: boolean
> + description:
> + Indicates that this is an Accessory Mode mux.
> +
> + port:
> + $ref: /schemas/graph.yaml#/properties/port
> + description:
> + OF graph bindings modelling a Type-C port controller.
What does that mean?
There's a couple of Type-C bindings on the list ATM. Without block
diagrams of all the relevant components and the corresponding graph, I
can't say whether any of this graph usage makes sense.
> +
> +required:
> + - compatible
> + - asel-gpio
> + - accessory
> + - port
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + usbaudiomux@0 {
> + compatible = "ti,ts5usba224";
> + asel-gpios = <&gpio1 7 GPIO_ACTIVE_HIGH>;
> + accessory;
> +
> + port {
> + usb_audio_mux1: endpoint {
> + remote-endpoint = <&typec1_mux>;
> + };
> + };
> + };
> --
> 2.35.1
>