Re: [PATCH v4 00/15] crypto: dh - infrastructure for NVM in-band auth and FIPS conformance

[Herbert Xu]

On Mon, Feb 21, 2022 at 01:10:46PM +0100, Nicolai Stange wrote:
> Hi all,
> 
> first of all, to the people primarily interested in security/keys/, there's
> a rather trivial change to security/keys/dh.c in patch 4/15. It would be
> great to get ACKs for that...
> 
> This patchset's main objective is to provide the DH related preprequisite
> bits needed by the upcoming support for NVME in-band authentication ([1]),
> namely
> - support for the RFC 7919 ffdheXYZ group parameters (patches [1-8/15]) and
> - an ephemeral key generation primitive for these (patches [9-11/15]).
> 
> With this in place, it happens to become relatively straight-forward to
> achieve conformance with NIST SP800-56Ar3. The remainder of this patchset,
> i.e. patches [12-15/15], implements the required changes.
> 
> The previous v3 of this patchset can be found at [2]. The only difference
> between v3 and the v4 here is the removal of a superfluous "default n"
> Kconfig statement in patch [7/15] ("crypto: dh - implement ffdheXYZ(dh)
> templates").
> 
> I would like to reiterate that [12/15] ("crypto: api - allow algs only in
> specific constructions in FIPS mode") is heavily based on a patch
> previously posted by Herbert. Please refer to the v3 cover letter at [2]
> for the full history.
> 
> Finally note that Stephan has granted his
> Tested-by: Stephan Mueller <smueller@xxxxxxxxxx>
> to v3 already ([3]). Stephan, with the trivial diff between v3 and v4,
> would you be Ok with carrying it over?
> 
> Thanks,
> 
> Nicolai
> 
> [1] https://lore.kernel.org/r/20211202152358.60116-1-hare@xxxxxxx
> [2] https://lore.kernel.org/r/20220202104012.4193-1-nstange@xxxxxxx
> [3] https://lore.kernel.org/r/8937519.l8FpVtv5Hg@xxxxxxxxxxxxxxxx
> 
> Nicolai Stange (15):
>   crypto: kpp - provide support for KPP template instances
>   crypto: kpp - provide support for KPP spawns
>   crypto: dh - remove struct dh's ->q member
>   crypto: dh - constify struct dh's pointer members
>   crypto: dh - split out deserialization code from crypto_dh_decode()
>   crypto: dh - introduce common code for built-in safe-prime group
>     support
>   crypto: dh - implement ffdheXYZ(dh) templates
>   crypto: testmgr - add known answer tests for ffdheXYZ(dh) templates
>   crypto: dh - implement private key generation primitive for
>     ffdheXYZ(dh)
>   crypto: testmgr - add keygen tests for ffdheXYZ(dh) templates
>   crypto: dh - allow for passing NULL to the ffdheXYZ(dh)s'
>     ->set_secret()
>   crypto: api - allow algs only in specific constructions in FIPS mode
>   crypto: dh - disallow plain "dh" usage in FIPS mode
>   lib/mpi: export mpi_rshift
>   crypto: dh - calculate Q from P for the full public key verification
> 
>  crypto/Kconfig                |    7 +
>  crypto/algapi.c               |   18 +-
>  crypto/api.c                  |   19 +-
>  crypto/dh.c                   |  687 +++++++++++++++-
>  crypto/dh_helper.c            |   42 +-
>  crypto/kpp.c                  |   29 +
>  crypto/tcrypt.c               |    4 +-
>  crypto/testmgr.c              |   61 +-
>  crypto/testmgr.h              | 1445 ++++++++++++++++++++++++++++++++-
>  include/crypto/dh.h           |   26 +-
>  include/crypto/internal/kpp.h |  158 ++++
>  include/linux/crypto.h        |    9 +
>  lib/mpi/mpi-bit.c             |    1 +
>  security/keys/dh.c            |    2 +-
>  14 files changed, 2441 insertions(+), 67 deletions(-)

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt