Re: [PATCH v1 3/3] auxdisplay: lcd2s: Use proper API to free the instance of charlcd object

[Miguel Ojeda]

On Wed, Feb 23, 2022 at 4:47 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> While it might work, the current approach is fragile in a few ways:
> - whenever members in the structure are shuffled, the pointer will be wrong
> - the resource freeing may include more than covered by kfree()
>
> Fix this by using charlcd_free() call instead of kfree().
>
> Fixes: 8c9108d014c5 ("auxdisplay: add a driver for lcd2s character display")
> Cc: Lars Poeschel <poeschel@xxxxxxxxxxx>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Thanks Andy, queued.

Cheers,
Miguel