Re: [PATCH net 1/1] net: stmmac: Resolve poor line rate after switching from TSO off to TSO on

[Jakub Kicinski]

On Mon, 28 Feb 2022 19:15:58 +0800 Wong Vee Khee wrote:
> From: Ling Pei Lee <pei.lee.ling@xxxxxxxxx>
> 
> Sequential execution of these steps:
> i) TSO ON – iperf3 execution,
> ii) TSO OFF – iperf3 execution,
> iii) TSO ON – iperf3 execution, it leads to iperf3 0 bytes transfer.

IMHO the iperf output can be dropped from the commit message, 
it doesn't add much beyond this description.

> Clear mss in TDES and call stmmac_enable_tso() to indicate
> a new TSO transmission when it is enabled from TSO off using
> ethtool command

How does the TSO get disabled I don't see any ...enable_tso(, 0, )
calls in the driver? And why call enable in fix_features rather 
than set_features?