Re: [PATCH v2] USB: serial: pl2303: Add IBM device IDs

[Joel Stanley]

On Thu, 3 Mar 2022 at 09:15, Johan Hovold <johan@xxxxxxxxxx> wrote:
>
> On Thu, Mar 03, 2022 at 08:52:29AM +0000, Joel Stanley wrote:
> > On Thu, 3 Mar 2022 at 08:25, Johan Hovold <johan@xxxxxxxxxx> wrote:
> > >
> > > On Tue, Mar 01, 2022 at 04:44:46PM -0600, Eddie James wrote:
> > > > IBM manufactures a PL2303 device for UPS communications. Add the vendor
> > > > and product IDs so that the PL2303 driver binds to the device.
> > > >
> > > > Signed-off-by: Joel Stanley <joel@xxxxxxxxx>
> > > > Signed-off-by: Eddie James <eajames@xxxxxxxxxxxxx>
> > > > ---
> > > > Changes since v1:
> > > >  - Fix commit message Signed-off-by ordering.
> > >
> > > Almost there. You're still missing a Co-developed-by tag, a From line,
> > > or both.
> >
> > It's neither. This patch was applied to a tree by myself, and I asked
> > Eddie to send it to mainline for merging.
>
> Then you are missing a From line. As the patch looks like know, Eddie is
> considered the author and not you.

You are incorrect. Eddie is the author.

>
> > Given it's come through me, and now has been sent to you, I think the
> > chain of s-o-b is appropriate.
>
> So the chain of SoB is correct, but the authorship is not.
>
> You can use git-format-patch and git-send-email to avoid this kind of
> problems, but just manually inserting a From line in the body of the
> mail works too.
>
> Johan