Re: [PATCH] power: supply: Handle error for wm8350_register_irq

[Charles Keepax]

On Thu, Mar 03, 2022 at 05:33:39PM +0800, Jiasheng Jiang wrote:
> As the potential failure of the wm8350_register_irq(),
> it should be better to check it and return error if fails.
> Also, use 'free_' in order to avoid same code.
> 
> Fixes: 14431aa0c5a4 ("power_supply: Add support for WM8350 PMU")
> Signed-off-by: Jiasheng Jiang <jiasheng@xxxxxxxxxxx>
> ---
> +	ret = wm8350_register_irq(wm8350, WM8350_IRQ_CHG_BAT_COLD,
>  			    wm8350_charger_handler, 0, "Battery cold", wm8350);
> -	wm8350_register_irq(wm8350, WM8350_IRQ_CHG_BAT_FAIL,
> +	if (ret)
> +		goto free_CHG_BAT_HOT;

Probably be nicer to use non-caps for the labels, otherwise looks
good to me.

Thanks,
Charles