Re: [PATCH] soundwire: qcom: fix build failures if CONFIG_PM=n

From: Srinivas Kandagatla
Date: Thu Mar 03 2022 - 11:29:02 EST




On 03/03/2022 15:55, Vinod Koul wrote:
On 03-03-22, 11:03, Srinivas Kandagatla wrote:
Fix below build failure
drivers/soundwire/qcom.c:1460:12: error: 'swrm_runtime_resume' defined
but not used [-Werror=unused-function]
by marking the resume swrm_runtime_resume() with __maybe_unused attribute.

A patch title should reflect the change and not the cause. So i have
taken liberty to fix it as:

soundwire: qcom: use __maybe_unused for swrm_runtime_resume()
swrm_runtime_resume() would not be defined when CONFIG_PM=n
This causes below build failure
drivers/soundwire/qcom.c:1460:12: error: 'swrm_runtime_resume' defined
but not used [-Werror=unused-function]
Mark the resume swrm_runtime_resume() with __maybe_unused attribute.

With this i have applied

Thanks Vinod,

--srini