Re: [PATCH v2] ACPI / x86: Work around broken XSDT on Advantech DAC-BJ01 board

[Hans de Goede]

Hi,

On 3/3/22 14:42, Mark Cilissen wrote:
> 
>> On 3 Mar 4 Reiwa, at 14:38, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>>
>> Hi Mark,
> 
> Hi Hans,
> 
>> On 3/2/22 21:20, Mark Cilissen wrote:
>>>>
>>
>> I think that there are a lot more boards that will have
>> DMI_BIOS_VENDOR == "Phoenix Technologies LTD"
>> then that there are boards that will have
>> DMI_PRODUCT_NAME == "Bearlake CRB Board"
>>
>> So if you want to make the DMI match as specific as possible then
>> IMHO dropping the bios-vendor match is best.
> 
> Of course, but just to clarify -- my proposal above is to drop
> 
>> DMI_MATCH(DMI_SYS_VENDOR, "NEC”),
> 
> not
> 
>> DMI_MATCH(DMI_PRODUCT_NAME, "Bearlake CRB Board”),
> 
> . :-)

Ah I see, I did indeed misunderstand that. Still NEC is not that
often seen as sys-vendor, so I still believe dropping the bios-vendor
match is best.

Regards,

Hans