Re: [PATCH v9 13/14] module: Move kdb_modules list out of core code

[Christophe Leroy]

Le 03/03/2022 à 18:54, Christoph Hellwig a écrit :
> On Thu, Mar 03, 2022 at 02:59:49PM +0000, Daniel Thompson wrote:
>>
>> One of the best ways that we can common up code might be to dust
>> off some code I wrote a while back to display seq_files from
>> kdb.
>>
>> The basic idea worked well enough but it often needs special
>> start/stop operatings to ensure the start meeds kdb's rather
>> odd locking restrictions. If there is a willingness for
>> something like the below to be included in the module code then we
>> could replace kdb_lsmod() with something that reused the code to
>>   format /proc/modules.
> 
> Displaying seq_files sounds nice to have, but in the short term I'm
> just thinking of something like this:

Well .... The idea at the first place was to get rid of the #ifdef 
CONFIG_KGDB_KDB in modules.

Here you propose it the other way round. Why not, in that case that 
would mean a dedicated file in kernel/module/ as part of the series 
https://patchwork.kernel.org/project/linux-modules/list/?series=618917&state=*

Christophe