Re: [PATCH v7 0/6] Raspberry Pi Sense HAT driver

[Miguel Ojeda]

On Thu, Mar 3, 2022 at 6:58 PM Charles Mirabile <cmirabil@xxxxxxxxxx> wrote:
>
>         - Changed userspace layout of the display driver to rgb565 triples
>           and removed the gamma table lookup and the associated ioctl. If
>           the user wants to recreate linear brightness scaling, they can
>           use a lookup table on their end. Doing this also removes a lot
>           of error checking and general code complexity, so I think removing
>           this feature is actually for the better.

Sounds better indeed! If I understood correctly how it worked in the
previous round, it should also allow to use the hardware to a fuller
extent.

>         - Replaced if statement with call to `min_t` function in display
>           read and write functions.
>         - Replaced the custom llseek implementation with a call to
>           `fixed_size_llseek`. Thanks to Miguel Ojeda for all of these
>           great suggestions.

You're very welcome!

Cheers,
Miguel