Re: [PATCH net-next 1/7] net: dev: use kfree_skb_reason() for sch_handle_egress()

[Menglong Dong]

On Fri, Mar 4, 2022 at 12:25 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Fri,  4 Mar 2022 01:47:01 +0800 menglong8.dong@xxxxxxxxx wrote:
> > Replace kfree_skb() used in sch_handle_egress() with kfree_skb_reason().
> > The drop reason SKB_DROP_REASON_QDISC_EGRESS is introduced. Considering
> > the code path of qdisc egerss, we make it distinct with the drop reason
> > of SKB_DROP_REASON_QDISC_DROP in the next commit.
>
> I don't think this has much to do with Qdiscs, this is the TC
> egress hook, it's more for filtering. Classful Qdisc like HTB
> will run its own classification. I think.
>
> Maybe TC_EGRESS?

You are right, I think I misunderstanded the concept of qdisc and tc before.
and seems all 'QDISC' here should be 'TC'? which means:

QDISC_EGRESS -> TC_EGRESS
QDISC_DROP -> TC_DROP
QDISC_INGRESS -> TC_INGRESS