Re: [PATCH v11 39/45] x86/sev: Use firmware-validated CPUID for SEV-SNP guests

From: Borislav Petkov
Date: Fri Mar 04 2022 - 02:43:42 EST


On Thu, Mar 03, 2022 at 06:31:57PM -0600, Michael Roth wrote:
> In that case it seems to expect "mce=option1 mce=option2" etc. I could
> open-code a parser to handle multiple options like sev=option1,option2
> etc., but wanted to check with you first.

Yap, that would make most sense - you want to be able to enable a couple
of options without excessive typing.

> Also, should I go ahead and introduce struct sev_options now, or
> just use a regular bool until more options are added later?

struct sev_config {
__u64 debug : 1,
__reserved : 63;
}

just like struct mca_config.

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette