RE: [EXT] [PATCH -next] drm/fsl-dcu: Remove unnecessary print function dev_err()

[Alison Wang]

Acked-by: Alison Wang <alison.wang@xxxxxxx>


Best Regards,
Alison Wang


-----Original Message-----
From: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx> 
Sent: 2022年3月3日 10:30
To: Alison Wang <alison.wang@xxxxxxx>
Cc: stefan@xxxxxxxx; airlied@xxxxxxxx; daniel@xxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>; Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
Subject: [EXT] [PATCH -next] drm/fsl-dcu: Remove unnecessary print function dev_err()

Caution: EXT Email

The print function dev_err() is redundant because platform_get_irq() already prints an error.

Eliminate the follow coccicheck warning:
./drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c:277:2-9: line 277 is redundant because platform_get_irq() already prints an error

Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
---
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
index 7a503bf08d0f..20895ea79739 100644
--- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
+++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
@@ -273,10 +273,8 @@ static int fsl_dcu_drm_probe(struct platform_device *pdev)
        }

        fsl_dev->irq = platform_get_irq(pdev, 0);
-       if (fsl_dev->irq < 0) {
-               dev_err(dev, "failed to get irq\n");
+       if (fsl_dev->irq < 0)
                return fsl_dev->irq;
-       }

        fsl_dev->regmap = devm_regmap_init_mmio(dev, base,
                        &fsl_dcu_regmap_config);
--[Alison Wang] r
2.20.1.7.g153144c