Re: [PATCH 2/2] pinctrl: ocelot: Fix interrupt parsing

From: Andy Shevchenko
Date: Fri Mar 04 2022 - 07:41:58 EST


On Fri, Mar 04, 2022 at 02:40:38PM +0200, Andy Shevchenko wrote:
> On Thu, Mar 03, 2022 at 09:37:16PM +0100, Horatiu Vultur wrote:
> > In the blamed commit, it removes the duplicate of_node assignment in the
> > driver. But the driver uses this before calling into of_gpio_dev_init to
> > determine if it needs to assign an IRQ chip to the GPIO. The fixes
> > consists in using of_node from dev.
>
> ...
>
> > - irq = irq_of_parse_and_map(gc->of_node, 0);
> > + irq = irq_of_parse_and_map(info->dev->of_node, 0);
>
> Why platform_get_irq() can't be used?

Or actually _optional() variant of it?

--
With Best Regards,
Andy Shevchenko