Re: [PATCH] scsi: megaraid: cleanup formatting of megaraid

[Tom Rix]

On 3/3/22 3:38 PM, Joe Perches wrote:
> On Fri, 2022-03-04 at 00:17 +0100, Miguel Ojeda wrote:
> > On Thu, Mar 3, 2022 at 11:44 PM Finn Thain <fthain@xxxxxxxxxxxxxx> wrote:
> > > Others might argue that they should always be changed from,
> > >
> > > /*
> > >   * this style
> > >   * of multiline comment
> > >   */
> > >
> > > to
> > >
> > > /* this style
> > >   * of multiline comment
> > >   */
> > In general, for things that the coding style guide talks about, we
> > should follow them, even if some subsystems do not (they can always
> > override in their folder if they really, really want it). So, here for
> > instance, the first one should be used.
> It's up to individual maintainers to each decide on what might be
> considered unnecessary churn for the subsystems they control.

clang-format does not have an opt-in mechanism like indent, it is 
all-or-nothing

What is done is all the settings in .clang-format and the default settings.

The churn level will be very high.

Until clang-format has an opt-in mechanism, I do not think clang-format 
should be used.

.clang-format should be moved to staging/ to reflect its not being ready 
status.

staging/ would be a good long term home. it's content should not need 
backporting and is more likely to have style issues.

Tom

> One argument is that churn leads to difficulty in backporting
> fixes to older 'stable' versions.
>
> I think the churn argument is overstated.