Re: [PATCH bpf-next v2] bpf: Replace strncpy() with strscpy()

From: Yonghong Song
Date: Fri Mar 04 2022 - 11:07:54 EST




On 3/3/22 11:04 PM, Yuntao Wang wrote:
Using strncpy() on NUL-terminated strings is considered deprecated[1].
Moreover, if the length of 'task->comm' is less than the destination buffer
size, strncpy() will NUL-pad the destination buffer, which is a needless
performance penalty.

Replacing strncpy() with strscpy() fixes all these issues.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings

Signed-off-by: Yuntao Wang <ytcoode@xxxxxxxxx>

Acked-by: Yonghong Song <yhs@xxxxxx>