Re: [PATCH v2] mips: DEC: honor CONFIG_MIPS_FP_SUPPORT=n

From: Maciej W. Rozycki
Date: Fri Mar 04 2022 - 11:17:50 EST


On Fri, 4 Mar 2022, Randy Dunlap wrote:

> --- linux-next-20220303.orig/arch/mips/dec/setup.c
> +++ linux-next-20220303/arch/mips/dec/setup.c
> @@ -746,6 +746,7 @@ void __init arch_init_irq(void)
> dec_interrupt[DEC_IRQ_HALT] = -1;
>
> /* Register board interrupts: FPU and cascade. */
> +#if defined(CONFIG_MIPS_FP_SUPPORT)
> if (dec_interrupt[DEC_IRQ_FPU] >= 0 && cpu_has_fpu) {
> struct irq_desc *desc_fpu;
> int irq_fpu;

Can you please make it:

if (IS_ENABLED(CONFIG_MIPS_FP_SUPPORT) &&
dec_interrupt[DEC_IRQ_FPU] >= 0 && cpu_has_fpu) {

so as not to add more #ifdef's where avoidable?

Maciej