Re: mmotm 2022-03-03-21-24 uploaded (security/apparmor/policy_unpack.o)

[John Johansen]

On 3/4/22 09:32, Randy Dunlap wrote:
> 
> 
> On 3/3/22 21:24, Andrew Morton wrote:
>> The mm-of-the-moment snapshot 2022-03-03-21-24 has been uploaded to
>>
>>    https://www.ozlabs.org/~akpm/mmotm/
>>
>> mmotm-readme.txt says
>>
>> README for mm-of-the-moment:
>>
>> https://www.ozlabs.org/~akpm/mmotm/
>>
>> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
>> more than once a week.
>>
>> You will need quilt to apply these patches to the latest Linus release (5.x
>> or 5.x-rcY).  The series file is in broken-out.tar.gz and is duplicated in
>> https://ozlabs.org/~akpm/mmotm/series
> 
> on x86_64:
> 
> ld: security/apparmor/policy_unpack.o: in function `deflate_compress':
> mmotm-2022-0303-2124/X64/../security/apparmor/policy_unpack.c:1069: undefined reference to `zlib_deflate_workspacesize'
> ld: mmotm-2022-0303-2124/X64/../security/apparmor/policy_unpack.c:1075: undefined reference to `zlib_deflateInit2'
> ld: mmotm-2022-0303-2124/X64/../security/apparmor/policy_unpack.c:1092: undefined reference to `zlib_deflate'
> ld: mmotm-2022-0303-2124/X64/../security/apparmor/policy_unpack.c:1122: undefined reference to `zlib_deflateEnd'
> 
> 
> 
> Full randconfig file is attached.
> 

yes thanks for the report,

the fix is already baking in apparmor-next
c2489617b3b9 apparmor: Fix undefined reference to `zlib_deflate_workspacesize'

this happens when CONFIG_SECURITY_APPARMOR_EXPORT_BINARY is not set and hence ZLIB_INFLATE/DEFLATE aren't selected and the kernel is configed without them. Basically some blocks of code need to be wrapped in #ifdef.