Re: [PATCH v2 1/1] serial: 8520_mtk: Prepare for platform_get_irq_optional() changes
From: Andy Shevchenko
Date: Fri Mar 04 2022 - 13:12:13 EST
On Fri, Dec 17, 2021 at 08:15:47PM +0200, Andy Shevchenko wrote:
> The platform_get_irq_optional() is going to be changed in a way
> that the result of it:
> = 0 means no IRQ is provided
> < 0 means the error which needs to be propagated to the upper layers
> > 0 valid vIRQ is allocated
>
> In this case, drop check for 0. Note, the 0 is not valid vIRQ and
> platform_get_irq_optional() issues a big WARN() in such case,
>
> It's safe to assume that 0 is not valid IRQ in this case since
> the driver is only instantiated via Device Tree and corresponding
> OF APIs should never ever return 0 for valid IRQ. Otherwise it is
> a regression there.
Can it be applied now?
--
With Best Regards,
Andy Shevchenko