Re: [PATCH] mm: thp: don't have to lock page anymore when splitting PMD

[Yang Shi]

On Fri, Mar 4, 2022 at 10:50 AM David Hildenbrand <david@xxxxxxxxxx> wrote:
>
> On 04.03.22 19:30, Yang Shi wrote:
> > On Thu, Mar 3, 2022 at 9:06 PM David Hildenbrand <david@xxxxxxxxxx> wrote:
> >>
> >> Hi,
> >>
> >> This probably bounces on the list due to html junk from the gmail app.
> >>
> >> What happened to
> >>
> >> https://lore.kernel.org/linux-mm/20220131162940.210846-10-david@xxxxxxxxxx/
> >>
> >> Included in the very series mentioned below?
> >>
> >> Was this silently dropped due to folio conversion collisions? :/
> >
> > I really didn't notice you already proposed this. Maybe folio
> > conversion, maybe mlock cleanup, I can't tell. But anyway this patch
> > needs to get rebased. I will submit v2 to solve the comment, will add
> > your signed-off-by.
> >
>
> Why a rebase? The folio change comes via another tree (unfortunately not
> Andrews tree, I wish we would have a single MM tree for MM patches).
>
> @Andrew, the last mail I received was
>
> + mm-huge_memory-remove-stale-locking-logic-from-__split_huge_pmd.patch
> added to -mm tree
>
> The patch shows up in mmotm as
>
> #[merged]mm-huge_memory-remove-stale-locking-logic-from-__split_huge_pmd.patch
>
> ... which shouldn't be true.

Yes, otherwise my patch can't be applied. What I saw on linux-next for
mm/huge_memory.c looks like:

bfede97b8d6d mm/huge_memory: remove stale page_trans_huge_mapcount()
6c127ac2ff1d mm/huge_memory: streamline COW logic in do_huge_pmd_wp_page()
cb63c1eb2a3c mm/migration: add trace events for THP migrations
e65f964148fe Merge branch 'akpm-current/current'
61435e1e267c mm/readahead: Align file mappings for non-DAX
80ef527bf929 mm: Turn can_split_huge_page() into can_split_folio()
8339af1d0a18 mm/rmap: Convert rmap_walk() to take a folio
16f06327291e mm/migrate: Convert remove_migration_ptes() to folios
bd23d3f12232 memory tiering: skip to scan fast memory
47a3e10abb78 mm: thp: fix wrong cache flush in remove_migration_pmd()
1de8566cca0a mm/rmap: Convert try_to_migrate() to folios
5a470d51cb2b mm/rmap: Convert try_to_unmap() to take a folio
1c760ad73a13 mm/huge_memory: Convert __split_huge_pmd() to take a folio
82865a9e1187 mm: Add folio_mapcount()
07ca76067308 mm/munlock: maintain page->mlock_count while unevictable
cea86fe246b6 mm/munlock: rmap call mlock_vma_page() munlock_vma_page()
b67bf49ce7aa mm/munlock: delete FOLL_MLOCK and FOLL_POPULATE
f56caedaf94f Merge branch 'akpm' (patches from Andrew)

It looks like your series were rebased on top of mlock cleanup and
folio. Anyway I will wait for Andrew. If he thought a new patch
rebased on top of both mlock cleanup and folio would make his life
easier, I will submit v2.

>
> --
> Thanks,
>
> David / dhildenb
>