Re: [PATCH -next] power: supply: da9150-fg: Remove unnecessary print function dev_err()

[Sebastian Reichel]

Hi,

On Tue, Mar 01, 2022 at 04:16:19PM +0800, Yang Li wrote:
> The print function dev_err() is redundant because
> platform_get_irq_byname() already prints an error.
> 
> Eliminate the follow coccicheck warning:
> ./drivers/power/supply/da9150-fg.c:524:2-9: line 524 is redundant
> because platform_get_irq() already prints an error
> 
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/da9150-fg.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/power/supply/da9150-fg.c b/drivers/power/supply/da9150-fg.c
> index e63fa62d1943..8c5e2c49d6c1 100644
> --- a/drivers/power/supply/da9150-fg.c
> +++ b/drivers/power/supply/da9150-fg.c
> @@ -520,10 +520,8 @@ static int da9150_fg_probe(struct platform_device *pdev)
>  
>  	/* Register IRQ */
>  	irq = platform_get_irq_byname(pdev, "FG");
> -	if (irq < 0) {
> -		dev_err(dev, "Failed to get IRQ FG: %d\n", irq);
> +	if (irq < 0)
>  		return irq;
> -	}
>  
>  	ret = devm_request_threaded_irq(dev, irq, NULL, da9150_fg_irq,
>  					IRQF_ONESHOT, "FG", fg);
> -- 
> 2.20.1.7.g153144c
>

Attachment: signature.asc
Description: PGP signature