Re: [PATCH V2 1/4] cpufreq: amd-pstate: Add more tracepoint for AMD P-State module

[Huang Rui]

On Sat, Mar 05, 2022 at 02:49:51AM +0800, Rafael J. Wysocki wrote:
> On Fri, Mar 4, 2022 at 7:42 AM Huang Rui <ray.huang@xxxxxxx> wrote:
> >
> > On Fri, Mar 04, 2022 at 02:07:21PM +0800, Su, Jinzhou (Joe) wrote:
> > > Add frequency, mperf, aperf and tsc in the trace. This can be used
> > > to debug and tune the performance of AMD P-state driver.
> > >
> > > Use the time difference between amd_pstate_update to calculate CPU
> > > frequency. There could be sleep in arch_freq_get_on_cpu, so do not
> > > use it here.
> > >
> > > Signed-off-by: Jinzhou Su <Jinzhou.Su@xxxxxxx>
> > > Co-developed-by: Huang Rui <ray.huang@xxxxxxx>
> > > Signed-off-by: Huang Rui <ray.huang@xxxxxxx>
> >
> > Let's remove "Signed-off-by" of me, just leave "Co-developed-by".
> 
> Actually, they both need to be present (the C-d-b clarifies the S-o-b
> meaning), so the above is correct.
> 

OK, I see. Thanks to clarify this.

Best Regards,
Ray