Re: [PATCH 1/2] cpufreq: unify the show() and store() styles of attr

From: Viresh Kumar
Date: Mon Mar 07 2022 - 00:54:06 EST


On 07-03-22, 11:22, Viresh Kumar wrote:
> On 07-03-22, 13:50, zhanglianjie wrote:
> > Usually /sys directory under the file, the corresponding Attribute contains
> > .show and .store, and their naming style is filename_show() and
> > filename_store(). But all naming style in 'cpufreq' is show_filename() and
> > store_filename(), So you need to change naming style.
>
> This is something that is present within the kernel and not exposed to
> userspace. I don't see why we would need to make this change and what
> good it brings.
>
> I would have supported this if cpufreq itself had different names, but
> for this one, No.

Or is it that you want to reuse __ATTR_RW() and __ATTR_RO() and the
current naming doesn't allow you that ?

I will let Rafael take a call on that.

--
viresh