Re: [PATCH v6 5/9] regmap: Introduces regmap lock helpers

From: Quan Nguyen
Date: Mon Mar 07 2022 - 03:31:36 EST


On 24/12/2021 20:19, Mark Brown wrote:
On Fri, Dec 24, 2021 at 11:13:48AM +0700, Quan Nguyen wrote:
This commit introduces regmap_acquire/release_lock() functions and makes
them available for drivers that need atomic access of regmap registers

You've not explained what something would need this for and how
it's expected to work - we don't provide unlocked access to the
regmap to client drivers so I don't see how one could safely use
this. It's unclear to me what this would mean or why it's not
better implemented in the client driver.

Thanks a lot for the review, Mark.
As per my comment in the other email, this code will be removed in my next version.

Thanks,
- Quan