Re: [PATCH v3 1/7] octeon_ep: Add driver framework and device initialization

[Leon Romanovsky]

On Mon, Mar 07, 2022 at 01:26:40AM -0800, Veerasenareddy Burru wrote:
> Add driver framework and device setup and initialization for Octeon
> PCI Endpoint NIC.
> 
> Add implementation to load module, initilaize, register network device,
> cleanup and unload module.
> 
> Signed-off-by: Veerasenareddy Burru <vburru@xxxxxxxxxxx>
> Signed-off-by: Abhijit Ayarekar <aayarekar@xxxxxxxxxxx>
> Signed-off-by: Satananda Burla <sburla@xxxxxxxxxxx>
> ---
> V2 -> V3:
>   - fix the Title overline & underline mismatch in octeon_ep.rst,
>     reported by kernel test robot:
>     Reported-by: kernel test robot <lkp@xxxxxxxxx>
> 
> V1 -> V2:
>   - split the patch into smaller patches.
>   - fix build errors observed with clang and "make W=1 C=1".
> 
>  .../device_drivers/ethernet/index.rst         |   1 +
>  .../ethernet/marvell/octeon_ep.rst            |  35 ++
>  MAINTAINERS                                   |   7 +
>  drivers/net/ethernet/marvell/Kconfig          |   1 +
>  drivers/net/ethernet/marvell/Makefile         |   1 +
>  .../net/ethernet/marvell/octeon_ep/Kconfig    |  20 +
>  .../net/ethernet/marvell/octeon_ep/Makefile   |   9 +
>  .../marvell/octeon_ep/octep_cn9k_pf.c         | 241 +++++++++
>  .../ethernet/marvell/octeon_ep/octep_config.h | 204 +++++++
>  .../marvell/octeon_ep/octep_ctrl_mbox.c       |  84 +++
>  .../marvell/octeon_ep/octep_ctrl_mbox.h       | 170 ++++++
>  .../marvell/octeon_ep/octep_ctrl_net.c        |  42 ++
>  .../marvell/octeon_ep/octep_ctrl_net.h        | 299 ++++++++++
>  .../ethernet/marvell/octeon_ep/octep_main.c   | 512 ++++++++++++++++++
>  .../ethernet/marvell/octeon_ep/octep_main.h   | 379 +++++++++++++
>  .../marvell/octeon_ep/octep_regs_cn9k_pf.h    | 367 +++++++++++++
>  .../net/ethernet/marvell/octeon_ep/octep_rx.c |  42 ++
>  .../net/ethernet/marvell/octeon_ep/octep_rx.h | 199 +++++++
>  .../net/ethernet/marvell/octeon_ep/octep_tx.c |  43 ++
>  .../net/ethernet/marvell/octeon_ep/octep_tx.h | 284 ++++++++++
>  20 files changed, 2940 insertions(+)
>  create mode 100644 Documentation/networking/device_drivers/ethernet/marvell/octeon_ep.rst
>  create mode 100644 drivers/net/ethernet/marvell/octeon_ep/Kconfig
>  create mode 100644 drivers/net/ethernet/marvell/octeon_ep/Makefile
>  create mode 100644 drivers/net/ethernet/marvell/octeon_ep/octep_cn9k_pf.c
>  create mode 100644 drivers/net/ethernet/marvell/octeon_ep/octep_config.h
>  create mode 100644 drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_mbox.c
>  create mode 100644 drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_mbox.h
>  create mode 100644 drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c
>  create mode 100644 drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.h
>  create mode 100644 drivers/net/ethernet/marvell/octeon_ep/octep_main.c
>  create mode 100644 drivers/net/ethernet/marvell/octeon_ep/octep_main.h
>  create mode 100644 drivers/net/ethernet/marvell/octeon_ep/octep_regs_cn9k_pf.h
>  create mode 100644 drivers/net/ethernet/marvell/octeon_ep/octep_rx.c
>  create mode 100644 drivers/net/ethernet/marvell/octeon_ep/octep_rx.h
>  create mode 100644 drivers/net/ethernet/marvell/octeon_ep/octep_tx.c
>  create mode 100644 drivers/net/ethernet/marvell/octeon_ep/octep_tx.h

<...>

> +MODULE_AUTHOR("Veerasenareddy Burru <vburru@xxxxxxxxxxx>");
> +MODULE_DESCRIPTION(OCTEP_DRV_STRING);
> +MODULE_LICENSE("GPL");
> +MODULE_VERSION(OCTEP_DRV_VERSION_STR);

Please don't add driver versions to new drivers.

Thanks