RE: [PATCH v9 2/2] clocksource: Add Intel Keem Bay timer support

[Sanil, Shruthi]

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Sent: Monday, March 7, 2022 7:15 PM
> To: Sanil, Shruthi <shruthi.sanil@xxxxxxxxx>
> Cc: daniel.lezcano@xxxxxxxxxx; tglx@xxxxxxxxxxxxx; robh+dt@xxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> mgross@xxxxxxxxxxxxxxx; Thokala, Srikanth <srikanth.thokala@xxxxxxxxx>;
> Raja Subramanian, Lakshmi Bai <lakshmi.bai.raja.subramanian@xxxxxxxxx>;
> Sangannavar, Mallikarjunappa <mallikarjunappa.sangannavar@xxxxxxxxx>
> Subject: Re: [PATCH v9 2/2] clocksource: Add Intel Keem Bay timer support
> 
> On Mon, Mar 07, 2022 at 05:01:47PM +0530, shruthi.sanil@xxxxxxxxx wrote:
> > From: Shruthi Sanil <shruthi.sanil@xxxxxxxxx>
> >
> > The Intel Keem Bay timer driver supports clocksource and clockevent
> > features for the timer IP used in Intel Keem Bay SoC.
> > The timer block supports 1 free running counter and 8 timers.
> > The free running counter can be used as a clocksource and the timers
> > can be used as clockevent. Each timer is capable of generating
> > individual interrupt.
> > Both the features are enabled through the timer general config register.
> 
> ...
> 
> > +		pr_err("%pOF: FW_BUG: Prescaler is not enabled\n", np);
> 
> FW_BUG is a macro. The above is an incorrect use of it.

Oh! I'll correct it and send the updated patch.

> 
> ...
> 
> > +		pr_err("%pOF: FW_BUG: free running counter is not
> enabled\n", np);
> 
> Ditto.
> 
> --
> With Best Regards,
> Andy Shevchenko
>