RE: [PATCH v3 02/12] dt-bindings: ufs: samsung,exynos-ufs: use common bindings

[Alim Akhtar]

>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@xxxxxxxxxxxxx]
>Sent: Sunday, March 6, 2022 4:41 PM
>To: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; Avri Altman
><avri.altman@xxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof
>Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>; Andy Gross
><agross@xxxxxxxxxx>; Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>; Wei
>Xu <xuwei5@xxxxxxxxxxxxx>; Matthias Brugger <matthias.bgg@xxxxxxxxx>;
>Jan Kotas <jank@xxxxxxxxxxx>; Li Wei <liwei213@xxxxxxxxxx>; Stanley Chu
><stanley.chu@xxxxxxxxxxxx>; Vignesh Raghavendra <vigneshr@xxxxxx>;
>linux-scsi@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
>kernel@xxxxxxxxxxxxxxx; linux-arm-msm@xxxxxxxxxxxxxxx; linux-arm-
>kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx; linux-
>mediatek@xxxxxxxxxxxxxxxxxxx
>Cc: Rob Herring <robh@xxxxxxxxxx>
>Subject: [PATCH v3 02/12] dt-bindings: ufs: samsung,exynos-ufs: use common
>bindings
>
>Use common UFS bindings in Samsung Exynos UFS to cover generic/common
>properties in DTS.
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
>Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
>---

Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>

> .../devicetree/bindings/ufs/samsung,exynos-ufs.yaml | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
>
>diff --git a/Documentation/devicetree/bindings/ufs/samsung,exynos-
>ufs.yaml b/Documentation/devicetree/bindings/ufs/samsung,exynos-
>ufs.yaml
>index 95ac1c18334d..c949eb617313 100644
>--- a/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
>+++ b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
>@@ -11,12 +11,11 @@ maintainers:
>
> description: |
>   Each Samsung UFS host controller instance should have its own node.
>-  This binding define Samsung specific binding other then what is used
>-  in the common ufshcd bindings
>-  [1] Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
>
>-properties:
>+allOf:
>+  - $ref: ufs-common.yaml
>
>+properties:
>   compatible:
>     enum:
>       - samsung,exynos7-ufs
>@@ -47,9 +46,6 @@ properties:
>       - const: core_clk
>       - const: sclk_unipro_main
>
>-  interrupts:
>-    maxItems: 1
>-
>   phys:
>     maxItems: 1
>
>@@ -67,13 +63,12 @@ properties:
> required:
>   - compatible
>   - reg
>-  - interrupts
>   - phys
>   - phy-names
>   - clocks
>   - clock-names
>
>-additionalProperties: false
>+unevaluatedProperties: false
>
> examples:
>   - |
>--
>2.32.0