Re: [PATCH] ARM: dts: at91: sama7g5ek: enable pull-up on flexcom3 console lines

[Tudor.Ambarus]

On 3/7/22 13:38, Eugen Hristev wrote:
> Flexcom3 is used as board console serial. There are no pull-ups on these
> lines on the board. This means that if a cable is not connected (that has
> pull-ups included), stray characters could appear on the console as the
> floating pins voltage levels are interpreted as incoming characters.
> To avoid this problem, enable the internal pull-ups on these lines.
> 
> Signed-off-by: Eugen Hristev <eugen.hristev@xxxxxxxxxxxxx>

Reviewed-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>

> ---
>  arch/arm/boot/dts/at91-sama7g5ek.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/at91-sama7g5ek.dts b/arch/arm/boot/dts/at91-sama7g5ek.dts
> index 08685a10eda1d..dd047a8523907 100644
> --- a/arch/arm/boot/dts/at91-sama7g5ek.dts
> +++ b/arch/arm/boot/dts/at91-sama7g5ek.dts
> @@ -495,7 +495,7 @@ pinctrl_flx0_default: flx0_default {
>  	pinctrl_flx3_default: flx3_default {
>  		pinmux = <PIN_PD16__FLEXCOM3_IO0>,
>  			 <PIN_PD17__FLEXCOM3_IO1>;
> -		bias-disable;
> +		bias-pull-up;
>  	};
>  
>  	pinctrl_flx4_default: flx4_default {