Re: [PATCH] linux/bits.h: fix -Wtype-limits warnings in GENMASK_INPUT_CHECK()

From: Andy Shevchenko
Date: Tue Mar 08 2022 - 07:33:37 EST


On Tue, Mar 8, 2022 at 2:22 PM Vincent MAILHOL
<mailhol.vincent@xxxxxxxxxx> wrote:
> On Tue. 8 Mar 2022 at 01:33, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
> > On Mon, Mar 7, 2022 at 4:06 PM Vincent MAILHOL
> > <mailhol.vincent@xxxxxxxxxx> wrote:
> > > On Mon. 7 Mar 2022 at 22:40, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:

...

> > > I do not understand why I should be forbidden to fix a W=2 in the
> > > file which I am maintaining on the grounds that some code to which
> > > I do not care still has some W=1.
> >
> > It's not forbidden. I said something different.
> >
> > Whatever, thank you for doing it, perhaps we will have less noise in W=2 case.
>
> Great! So does it mean you are withdrawing your NAK?
> Or do you still have concern on the patch itself?

I'm not stopping you from amending a commit message (including
dropping noise from it and leaving only a partial example of the
compiler complaint), Cc'ing a new version to the people from this and
the discussion mentioned previously.

--
With Best Regards,
Andy Shevchenko