Re: [PATCH 1/3] mm: vmalloc: introduce array allocation functions

From: Michal Hocko
Date: Tue Mar 08 2022 - 10:26:36 EST


On Tue 08-03-22 14:55:39, Paolo Bonzini wrote:
> On 3/8/22 14:47, Michal Hocko wrote:
> > Seems useful
> > Acked-by: Michal Hocko<mhocko@xxxxxxxx>
> >
> > Is there any reason you haven't used __alloc_size(1, 2) annotation?
>
> It's enough to have them in the header:
>
> > > +extern void *__vmalloc_array(size_t n, size_t size, gfp_t flags) __alloc_size(1, 2);
> > > +extern void *vmalloc_array(size_t n, size_t size) __alloc_size(1, 2);
> > > +extern void *__vcalloc(size_t n, size_t size, gfp_t flags) __alloc_size(1, 2);
> > > +extern void *vcalloc(size_t n, size_t size) __alloc_size(1, 2);

My bad, I have expected __alloc_size before the function name and simply
haven't noticed it at the end.
--
Michal Hocko
SUSE Labs