Re: [PATCH 0/4] x86/acpi/cppc: Minor clean up for x86 CPPC implementation

From: Rafael J. Wysocki
Date: Tue Mar 08 2022 - 13:18:50 EST


On Tue, Mar 1, 2022 at 8:20 PM Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
>
> On Mon, Feb 14, 2022 at 11:51 AM Huang Rui <ray.huang@xxxxxxx> wrote:
> >
> > Hi all,
> >
> > While we were fixing the legacy issue below, we found the dependencies
> > between smpboot and CPPC were not very good. But due to urgent fix for
> > 5.17-rc1, I didn't have much time to provide a complete solution.
> >
> > https://lore.kernel.org/lkml/YdeWDDCwBQAYnlKb@xxxxxxx/
> >
> > In these series, I expand the scope of acpi/cppc_msr to acpi/cppc to cover
> > the all the CPPC helper functions for x86 ACPI. And then clean up the
> > smpboot and move CPPC related functions into the acpi/cppc.c. This design
> > is more straightforward and more clear to handle the CPPC in x86 and
> > resolve dependency issues between CPPC and smpboot.c.
> >
> > Thanks,
> > Ray
> >
> > Huang Rui (4):
> > x86/acpi: Expand the CPPC MSR file to cover the whole CPPC
> > implementation
> > x86, sched: Move AMD maximum frequency ratio setting function into x86
> > CPPC
> > x86, sched: Expose init_freq_invariance to topology header
> > x86/acpi: Move init_freq_invariance_cppc into x86 CPPC
> >
> > arch/x86/include/asm/topology.h | 13 +++-
> > arch/x86/kernel/acpi/Makefile | 2 +-
> > arch/x86/kernel/acpi/cppc.c | 103 ++++++++++++++++++++++++++++++++
> > arch/x86/kernel/acpi/cppc_msr.c | 49 ---------------
> > arch/x86/kernel/smpboot.c | 72 +---------------------
> > 5 files changed, 118 insertions(+), 121 deletions(-)
> > create mode 100644 arch/x86/kernel/acpi/cppc.c
> > delete mode 100644 arch/x86/kernel/acpi/cppc_msr.c
> >
> > --
>
> This series makes sense to me and I'm inclined to take it if there are
> no objections, so if there are any, please let me know.

And so applied as 5.18 material now with slightly adjusted subjects.

Thanks!