Re: [PATCH] ACPI: APEI: fix return value of __setup handlers

[Rafael J. Wysocki]

On Mon, Mar 7, 2022 at 2:51 AM Huang, Ying <ying.huang@xxxxxxxxx> wrote:
>
> Randy Dunlap <rdunlap@xxxxxxxxxxxxx> writes:
>
> > __setup() handlers should return 1 to indicate that the boot option
> > has been handled. Returning 0 causes a boot option to be listed in
> > the Unknown kernel command line parameters and also added to init's
> > arg list (if no '=' sign) or environment list (if of the form 'a=b').
> >
> > Unknown kernel command line parameters "erst_disable
> >   bert_disable hest_disable BOOT_IMAGE=/boot/bzImage-517rc6", will be
> >   passed to user space.
> >
> >  Run /sbin/init as init process
> >    with arguments:
> >      /sbin/init
> >      erst_disable
> >      bert_disable
> >      hest_disable
> >    with environment:
> >      HOME=/
> >      TERM=linux
> >      BOOT_IMAGE=/boot/bzImage-517rc6
> >
> > Fixes: a3e2acc5e37b ("ACPI / APEI: Add Boot Error Record Table (BERT) support")
> > Fixes: a08f82d08053 ("ACPI, APEI, Error Record Serialization Table (ERST) support")
> > Fixes: 9dc966641677 ("ACPI, APEI, HEST table parsing")
> > Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
> Good catch!  Thanks for fixing!
>
> Reviewed-by: "Huang, Ying" <ying.huang@xxxxxxxxx>

Applied as 5.18 material, thanks!