Re: [PATCH 5.15 000/256] 5.15.27-rc2 review

From: Guenter Roeck
Date: Tue Mar 08 2022 - 18:07:27 EST


On 3/8/22 13:05, Greg Kroah-Hartman wrote:
On Tue, Mar 08, 2022 at 11:08:10PM +0530, Naresh Kamboju wrote:


[ ... ]


Reverting 4778338032b3 ("MIPS: fix local_{add,sub}_return on MIPS64")
has fixed all the 3 build failures.

MIPS: fix local_{add,sub}_return on MIPS64
[ Upstream commit 277c8cb3e8ac199f075bf9576ad286687ed17173 ]

Use "daddu/dsubu" for long int on MIPS64 instead of "addu/subu"

Fixes: 7232311ef14c ("local_t: mips extension")
Signed-off-by: Huang Pei <huangpei@xxxxxxxxxxx>
Signed-off-by: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>
Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

Ah, I'll queue up the revert for that in the morning, thanks for finding
it. Odd it doesn't trigger the same issue in 5.16.y.


If you don't want to revert: the fix needs the following two patches:

e5b40668e93 ("slip: fix macro redefine warning")
b81e0c2372e ("block: drop unused includes in <linux/genhd.h>")

Both are in v5.16, so you won't see the problem there.

Guenter