Re: [PATCH v4 04/45] objtool,efi: Update __efi64_thunk annotation

[Miroslav Benes]

> --- a/arch/x86/platform/efi/efi_thunk_64.S
> +++ b/arch/x86/platform/efi/efi_thunk_64.S
> @@ -20,12 +20,14 @@
>   */
>  
>  #include <linux/linkage.h>
> +#include <linux/objtool.h>
>  #include <asm/page_types.h>
>  #include <asm/segment.h>
>  
>  	.text
>  	.code64
> -SYM_CODE_START(__efi64_thunk)
> +SYM_FUNC_START(__efi64_thunk)
> +STACK_FRAME_NON_STANDARD __efi64_thunk

I would prefer if STACK_FRAME_NON_STANDARD annotation...

>  	push	%rbp
>  	push	%rbx
>  
> @@ -79,7 +81,7 @@ SYM_CODE_START(__efi64_thunk)
>  2:	pushl	$__KERNEL_CS
>  	pushl	%ebp
>  	lret
> -SYM_CODE_END(__efi64_thunk)
> +SYM_FUNC_END(__efi64_thunk)

went here after SYM_FUNC_END(), but that is just a cosmetic nit.

Miroslav