Re: [PATCH V3] ata: pata_pxa: Use platform_get_irq() to get the interrupt

[Sergei Shtylyov]

On 09.03.2022 10:31, Damien Le Moal wrote:

> > From: Minghao Chi <chi.minghao@xxxxxxxxxx>
> >
> > platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
> > allocation of IRQ resources in DT core code, this causes an issue
> > when using hierarchical interrupt domains using "interrupts" property
> > in the node as this bypasses the hierarchical setup and messes up the
> > irq chaining.
> >
> > In preparation for removal of static setup of IRQ resource from DT core
> > code use platform_get_irq().
> >
> > v1->v2:
> >      - Use more specific in the subject: ata: pata_pxa:
> >      - Switch to returning 'irq'
> > v2->v3:
> >      - drop the unlikely()
>
> Looks good. FYI, the changelog above should be placed under the "---"
> after your Signed-off-by so that it does not stay as part of the commit
> message. No need to resend, I will remove this when applying.
>
> Sergey,
>
> Review OK ?

   Yes.
   Although, strictly speaking, we still need to check for IRQ0 as well...

MBR, Sergey