Re: [PATCH] net: netdevsim: fix byte order on ipsec debugfs file

[Kleber Souza]

On 09.03.22 06:58, Jakub Kicinski wrote:
> On Tue,  8 Mar 2022 14:51:06 +0100 Kleber Sacilotto de Souza wrote:
> > When adding a new xfrm state, the data provided via struct xfrm_state
> > is stored in network byte order. This needs to be taken into
> > consideration when exporting the SAs data to userspace via debugfs,
> > otherwise the content will depend on the system endianness. Fix this by
> > converting all multi-byte fields from network to host order.
> >
> > Also fix the selftest script which was expecting the data as exported by
> > a little-endian system, which was inverted.
> >
> > Fixes: 7699353da875 ("netdevsim: add ipsec offload testing")
> > Fixes: 2766a11161cc ("selftests: rtnetlink: add ipsec offload API test")
> > Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@xxxxxxxxxxxxx>
>
> Then the struct members need to have the correct types,
> as is this patch adds sparse warnings (build with C=1).

Hi Jakub,

Thank you for the review. I'll fix it and send a v2 shortly.

Kleber