RE: [PATCH v9 4/9] hisi_acc_vfio_pci: add new vfio_pci driver for HiSilicon ACC devices

From: Tian, Kevin
Date: Wed Mar 09 2022 - 05:12:53 EST

> From: Shameer Kolothum <shameerali.kolothum.thodi@xxxxxxxxxx>
> Sent: Wednesday, March 9, 2022 2:49 AM
>
> Add a vendor-specific vfio_pci driver for HiSilicon ACC devices.
> This will be extended in subsequent patches to add support for VFIO
> live migration feature.
>
> Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@xxxxxxxxxx>

Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>

> ---
> MAINTAINERS | 7 ++
> drivers/vfio/pci/Kconfig | 2 +
> drivers/vfio/pci/Makefile | 2 +
> drivers/vfio/pci/hisilicon/Kconfig | 10 ++
> drivers/vfio/pci/hisilicon/Makefile | 4 +
> .../vfio/pci/hisilicon/hisi_acc_vfio_pci.c | 100 ++++++++++++++++++
> 6 files changed, 125 insertions(+)
> create mode 100644 drivers/vfio/pci/hisilicon/Kconfig
> create mode 100644 drivers/vfio/pci/hisilicon/Makefile
> create mode 100644 drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4322b5321891..48e09ca666c2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -20305,6 +20305,13 @@ L: kvm@xxxxxxxxxxxxxxx
> S: Maintained
> F: drivers/vfio/fsl-mc/
>
> +VFIO HISILICON PCI DRIVER
> +M: Longfang Liu <liulongfang@xxxxxxxxxx>
> +M: Shameer Kolothum <shameerali.kolothum.thodi@xxxxxxxxxx>
> +L: kvm@xxxxxxxxxxxxxxx
> +S: Maintained
> +F: drivers/vfio/pci/hisilicon/
> +
> VFIO MEDIATED DEVICE DRIVERS
> M: Kirti Wankhede <kwankhede@xxxxxxxxxx>
> L: kvm@xxxxxxxxxxxxxxx
> diff --git a/drivers/vfio/pci/Kconfig b/drivers/vfio/pci/Kconfig
> index 187b9c259944..4da1914425e1 100644
> --- a/drivers/vfio/pci/Kconfig
> +++ b/drivers/vfio/pci/Kconfig
> @@ -46,4 +46,6 @@ endif
>
> source "drivers/vfio/pci/mlx5/Kconfig"
>
> +source "drivers/vfio/pci/hisilicon/Kconfig"
> +
> endif
> diff --git a/drivers/vfio/pci/Makefile b/drivers/vfio/pci/Makefile
> index ed9d6f2e0555..7052ebd893e0 100644
> --- a/drivers/vfio/pci/Makefile
> +++ b/drivers/vfio/pci/Makefile
> @@ -9,3 +9,5 @@ vfio-pci-$(CONFIG_VFIO_PCI_IGD) += vfio_pci_igd.o
> obj-$(CONFIG_VFIO_PCI) += vfio-pci.o
>
> obj-$(CONFIG_MLX5_VFIO_PCI) += mlx5/
> +
> +obj-$(CONFIG_HISI_ACC_VFIO_PCI) += hisilicon/
> diff --git a/drivers/vfio/pci/hisilicon/Kconfig
> b/drivers/vfio/pci/hisilicon/Kconfig
> new file mode 100644
> index 000000000000..dc723bad05c2
> --- /dev/null
> +++ b/drivers/vfio/pci/hisilicon/Kconfig
> @@ -0,0 +1,10 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +config HISI_ACC_VFIO_PCI
> + tristate "VFIO PCI support for HiSilicon ACC devices"
> + depends on ARM64 || (COMPILE_TEST && 64BIT)
> + depends on VFIO_PCI_CORE
> + help
> + This provides generic PCI support for HiSilicon ACC devices
> + using the VFIO framework.
> +
> + If you don't know what to do here, say N.
> diff --git a/drivers/vfio/pci/hisilicon/Makefile
> b/drivers/vfio/pci/hisilicon/Makefile
> new file mode 100644
> index 000000000000..c66b3783f2f9
> --- /dev/null
> +++ b/drivers/vfio/pci/hisilicon/Makefile
> @@ -0,0 +1,4 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +obj-$(CONFIG_HISI_ACC_VFIO_PCI) += hisi-acc-vfio-pci.o
> +hisi-acc-vfio-pci-y := hisi_acc_vfio_pci.o
> +
> diff --git a/drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c
> b/drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c
> new file mode 100644
> index 000000000000..8129c3457b3b
> --- /dev/null
> +++ b/drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c
> @@ -0,0 +1,100 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (c) 2021, HiSilicon Ltd.
> + */
> +
> +#include <linux/device.h>
> +#include <linux/eventfd.h>
> +#include <linux/file.h>
> +#include <linux/hisi_acc_qm.h>
> +#include <linux/interrupt.h>
> +#include <linux/module.h>
> +#include <linux/pci.h>
> +#include <linux/vfio.h>
> +#include <linux/vfio_pci_core.h>
> +
> +static int hisi_acc_vfio_pci_open_device(struct vfio_device *core_vdev)
> +{
> + struct vfio_pci_core_device *vdev =
> + container_of(core_vdev, struct vfio_pci_core_device, vdev);
> + int ret;
> +
> + ret = vfio_pci_core_enable(vdev);
> + if (ret)
> + return ret;
> +
> + vfio_pci_core_finish_enable(vdev);
> +
> + return 0;
> +}
> +
> +static const struct vfio_device_ops hisi_acc_vfio_pci_ops = {
> + .name = "hisi-acc-vfio-pci",
> + .open_device = hisi_acc_vfio_pci_open_device,
> + .close_device = vfio_pci_core_close_device,
> + .ioctl = vfio_pci_core_ioctl,
> + .device_feature = vfio_pci_core_ioctl_feature,
> + .read = vfio_pci_core_read,
> + .write = vfio_pci_core_write,
> + .mmap = vfio_pci_core_mmap,
> + .request = vfio_pci_core_request,
> + .match = vfio_pci_core_match,
> +};
> +
> +static int hisi_acc_vfio_pci_probe(struct pci_dev *pdev, const struct
> pci_device_id *id)
> +{
> + struct vfio_pci_core_device *vdev;
> + int ret;
> +
> + vdev = kzalloc(sizeof(*vdev), GFP_KERNEL);
> + if (!vdev)
> + return -ENOMEM;
> +
> + vfio_pci_core_init_device(vdev, pdev, &hisi_acc_vfio_pci_ops);
> +
> + ret = vfio_pci_core_register_device(vdev);
> + if (ret)
> + goto out_free;
> +
> + dev_set_drvdata(&pdev->dev, vdev);
> +
> + return 0;
> +
> +out_free:
> + vfio_pci_core_uninit_device(vdev);
> + kfree(vdev);
> + return ret;
> +}
> +
> +static void hisi_acc_vfio_pci_remove(struct pci_dev *pdev)
> +{
> + struct vfio_pci_core_device *vdev = dev_get_drvdata(&pdev->dev);
> +
> + vfio_pci_core_unregister_device(vdev);
> + vfio_pci_core_uninit_device(vdev);
> + kfree(vdev);
> +}
> +
> +static const struct pci_device_id hisi_acc_vfio_pci_table[] = {
> + { PCI_DRIVER_OVERRIDE_DEVICE_VFIO(PCI_VENDOR_ID_HUAWEI,
> PCI_DEVICE_ID_HUAWEI_SEC_VF) },
> + { PCI_DRIVER_OVERRIDE_DEVICE_VFIO(PCI_VENDOR_ID_HUAWEI,
> PCI_DEVICE_ID_HUAWEI_HPRE_VF) },
> + { PCI_DRIVER_OVERRIDE_DEVICE_VFIO(PCI_VENDOR_ID_HUAWEI,
> PCI_DEVICE_ID_HUAWEI_ZIP_VF) },
> + { }
> +};
> +
> +MODULE_DEVICE_TABLE(pci, hisi_acc_vfio_pci_table);
> +
> +static struct pci_driver hisi_acc_vfio_pci_driver = {
> + .name = KBUILD_MODNAME,
> + .id_table = hisi_acc_vfio_pci_table,
> + .probe = hisi_acc_vfio_pci_probe,
> + .remove = hisi_acc_vfio_pci_remove,
> + .err_handler = &vfio_pci_core_err_handlers,
> +};
> +
> +module_pci_driver(hisi_acc_vfio_pci_driver);
> +
> +MODULE_LICENSE("GPL v2");
> +MODULE_AUTHOR("Liu Longfang <liulongfang@xxxxxxxxxx>");
> +MODULE_AUTHOR("Shameer Kolothum
> <shameerali.kolothum.thodi@xxxxxxxxxx>");
> +MODULE_DESCRIPTION("HiSilicon VFIO PCI - Generic VFIO PCI driver for
> HiSilicon ACC device family");
> --
> 2.25.1