[intel-tdx:kvm 24/193] arch/x86/kernel/cpu/tsx.c:186:5: warning: no previous prototype for function 'tsx_ctrl_clear'

From: kernel test robot
Date: Wed Mar 09 2022 - 05:58:13 EST


Hi Isaku,

FYI, the error/warning still remains.

tree: https://github.com/intel/tdx.git kvm
head: 7a7d51d52f45bbd82e264c7f940d74491305f5ce
commit: 2c9aac7eef8430d99ae51f243da09dd7892dc9cd [24/193] x86/cpu/tsx: Add helper functions to save/restore IA32_TSX_CTRL MSR
config: i386-randconfig-a013 (https://download.01.org/0day-ci/archive/20220309/202203091813.vrTfwPUD-lkp@xxxxxxxxx/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 276ca87382b8f16a65bddac700202924228982f6)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel/tdx/commit/2c9aac7eef8430d99ae51f243da09dd7892dc9cd
git remote add intel-tdx https://github.com/intel/tdx.git
git fetch --no-tags intel-tdx kvm
git checkout 2c9aac7eef8430d99ae51f243da09dd7892dc9cd
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash arch/x86/kernel/cpu/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> arch/x86/kernel/cpu/tsx.c:186:5: warning: no previous prototype for function 'tsx_ctrl_clear' [-Wmissing-prototypes]
u64 tsx_ctrl_clear(void)
^
arch/x86/kernel/cpu/tsx.c:186:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
u64 tsx_ctrl_clear(void)
^
static
>> arch/x86/kernel/cpu/tsx.c:199:6: warning: no previous prototype for function 'tsx_ctrl_restore' [-Wmissing-prototypes]
void tsx_ctrl_restore(u64 tsx_ctrl)
^
arch/x86/kernel/cpu/tsx.c:199:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void tsx_ctrl_restore(u64 tsx_ctrl)
^
static
2 warnings generated.


vim +/tsx_ctrl_clear +186 arch/x86/kernel/cpu/tsx.c

184
185 /* Clear the MSR_TSX_CTRL and return the old value if supported */
> 186 u64 tsx_ctrl_clear(void)
187 {
188 u64 tsx_ctrl = 0;
189
190 if (ia32_tsx_ctrl_supported) {
191 rdmsrl(MSR_IA32_TSX_CTRL, tsx_ctrl);
192 if (tsx_ctrl & MSR_TSX_CTRL_MASK)
193 wrmsrl(MSR_IA32_TSX_CTRL, tsx_ctrl & ~MSR_TSX_CTRL_MASK);
194 }
195 return tsx_ctrl;
196 }
197 EXPORT_SYMBOL_GPL(tsx_ctrl_clear);
198
> 199 void tsx_ctrl_restore(u64 tsx_ctrl)

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx