Re: [PATCH 10/10] Constify comedi_lrange struct pointers

[Ian Abbott]

On 09/03/2022 09:20, Hatim Muhammed wrote:
> From: Hatim Muhammed <hatimmohammed369@xxxxxxxxx>
>
> Signed-off-by: Hatim Muhammed <hatimmohammed369@xxxxxxxxx>
> ---
>   drivers/comedi/drivers/jr3_pci.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/comedi/drivers/jr3_pci.c b/drivers/comedi/drivers/jr3_pci.c
> index 951c23fa0369..f2a750a9112c 100644
> --- a/drivers/comedi/drivers/jr3_pci.c
> +++ b/drivers/comedi/drivers/jr3_pci.c
> @@ -90,8 +90,8 @@ struct jr3_pci_dev_private {
>   };
>   
>   union jr3_pci_single_range {
> -	struct comedi_lrange l;
> -	char _reserved[offsetof(struct comedi_lrange, range[1])];
> +	const struct comedi_lrange l;
> +	char _reserved[offsetof(const struct comedi_lrange, range[1])];
>   };
>   
>   enum jr3_pci_poll_state {

NAK. That really should not be const.

--
-=( Ian Abbott <abbotti@xxxxxxxxx> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-